Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddyhttp: Move HTTP redirect listener to an optional module #4585

Merged
merged 1 commit into from
Feb 19, 2022
Merged

caddyhttp: Move HTTP redirect listener to an optional module #4585

merged 1 commit into from
Feb 19, 2022

Conversation

francislavoie
Copy link
Member

Followup to #4313

Turns out we have some issues with this being turned on by default, so we'll have to provide it as an optional module for now.

To turn it on, this needs to be added in global options:

{
	servers {
		listener_wrappers {
			http_redirect
			tls
		}
	}
}

@francislavoie francislavoie added the bug 🐞 Something isn't working label Feb 19, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Feb 19, 2022
@francislavoie francislavoie requested a review from mholt February 19, 2022 06:41
mholt
mholt requested changes Feb 19, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Francis, this should do the trick. Looks good! Just a nit on the naming.

modules/caddyhttp/httpredirectlistener.go Outdated Show resolved Hide resolved
@francislavoie francislavoie force-pushed the http-redirect-wrapper-module branch from d990577 to 45df089 Compare February 19, 2022 22:30
@francislavoie francislavoie requested a review from mholt February 19, 2022 22:30
mholt
mholt approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks Francis!

@mholt mholt merged commit 186fdba into master Feb 19, 2022
@mholt mholt deleted the http-redirect-wrapper-module branch February 19, 2022 22:36
@francislavoie francislavoie mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@francislavoie @mholt