Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reverseproxy: Avoid returning a nil error during GetClientCertificate #4550

Merged
merged 1 commit into from
Feb 2, 2022
Merged

reverseproxy: Avoid returning a nil error during GetClientCertificate #4550

merged 1 commit into from
Feb 2, 2022

Conversation

francislavoie
Copy link
Member

Fix #4509

@francislavoie francislavoie added the bug 🐞 Something isn't working label Jan 27, 2022
@francislavoie francislavoie added this to the v2.5.0 milestone Jan 27, 2022
@francislavoie francislavoie requested a review from mholt January 27, 2022 08:35
mholt
mholt approved these changes Feb 2, 2022
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure how I missed this.

@mholt mholt merged commit 7557d1d into master Feb 2, 2022
@mholt mholt deleted the fix-proxy-client-cert-automate branch February 2, 2022 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
bug 🐞 Something isn't working
Projects
None yet
Milestone
v2.5.0
Development

Successfully merging this pull request may close these issues.

SIGSEGV in sendClientCertificate
2 participants
@francislavoie @mholt