metrics: Enforce smaller set of method labels #4545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francislavoie
added
bug 🐞
francislavoie
approved these changes
Jan 23, 2022
mholt
requested changes
Jan 23, 2022
|
@mholt I've merged the common sanitize functions into an |
mholt
requested changes
Jan 24, 2022
mholt
approved these changes
Jan 25, 2022
Signed-off-by: Dave Henderson <[email protected]>
Signed-off-by: Dave Henderson <[email protected]>
Signed-off-by: Dave Henderson <[email protected]>
hairyhenderson
force-pushed
the
metrics-restrict-http-methods
branch
from
dcafbf4 to
7ca5921
Compare
|
Nice work Dave, thank you so much for helping with this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Protects against unbounded cardinality on the method label.
Note: I'm finding myself copying code again between the two metrics endpoints - how do we feel about
internal/? I ask because there's no use of it yet... Otherwise I think I'd rather throw the common code in aninternal/metricspackage or something like that...Signed-off-by: Dave Henderson [email protected]