explain cryptic unix socket listener error related to process kill #4534
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
requested changes
Jan 19, 2022
There was a problem hiding this comment.
Well, this is quite a bit more intense than what I had in mind. The information in this error is worded more like a documentation page. Instead, the error should be short and concise, like "always exit Caddy gracefully," or "this can happen if Caddy is forcefully killed." And we can just use fmt.Errorf with %w to modify the error message.
francislavoie
added
the
documentation 📚
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
previous PR: #4533
here is a simple demo of the error being caught and the error message being displayed: https://go.dev/play/p/ehz0pTPjMwZ