Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fileserver: Fix handling of symlink sizes in directory listings #4415

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

jjlin
Copy link
Contributor

@jjlin jjlin commented Nov 12, 2021

Fixes #4411.

@francislavoie francislavoie added this to the v2.5.0 milestone Nov 12, 2021
@francislavoie francislavoie added the bug 🐞 Something isn't working label Nov 12, 2021
@francislavoie francislavoie requested a review from mholt November 12, 2021 10:45
@mcguirepr89
Copy link

Hello, @jjlin

Also, it would probably be better to move this discussion over to #4415 since your issue is really with that specific implementation.

It's a bit difficult to determine what's really going wrong without access to your environment.

I'm happy to provide remote access to this environment -- simply provide an email address for correspondence and I will gladly allow access for further investigation. (NoMachine is already installed on the machine for remote access).

Could you maybe pare down your directory structure and config to create a minimal reproducible example?

If you would prefer I put together a minimal reproducible example over the actual environment, I can do that instead.

@jjlin
Copy link
Contributor Author

jjlin commented Nov 15, 2021

@mcguirepr89 You can email me at <firstname>.<lastname>@gmail.com.

@mcguirepr89
Copy link

@jjlin deserves a great deal of gratitude for this patience with me -- I did not build this using the correct branch. Thank you so much for your time and I do apologize again for taking it needlessly.

My best regards,
Patrick

@mcguirepr89
Copy link

I can verify that fix-symlink-size resolved my issue

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the patch :)

@mholt mholt merged commit c8b5a81 into caddyserver:master Nov 22, 2021
@jjlin jjlin deleted the fix-symlink-size branch November 22, 2021 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.4.6 regression: presence of symlink breaks file_server browse
4 participants