Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

caddytls: Mark storage clean timestamp at end of routine #4401

Merged
merged 1 commit into from
Nov 2, 2021

Conversation

mholt
Copy link
Member

@mholt mholt commented Oct 28, 2021

See discussion on 42b7134

/cc @Gr33nbl00d

@mholt mholt added this to the v2.4.6 milestone Oct 28, 2021
@francislavoie francislavoie added bug 🐞 Something isn't working under review 🧐 Review is pending before merging labels Oct 31, 2021
@Gr33nbl00d
Copy link
Contributor

I think that should do it,
Only remark is what will happen if there is a panic during cleanup. Not sure we would need to handle this case.
But if we define a defer function after the condition which actually would set the finishTime we could avoid multiple fast retrys on panic.

@mholt
Copy link
Member Author

mholt commented Nov 2, 2021

I don't think multiple fast retries will be a concern here. I could be wrong, but I'd rather wait and see if that's actually the case because timers still call this function.

@mholt mholt merged commit 24fda75 into master Nov 2, 2021
@mholt mholt deleted the storage-clean branch November 2, 2021 14:27
@mholt mholt removed the under review 🧐 Review is pending before merging label Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐞 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants