fileserver: Fix compression breaks using httpInclude (#4352) #4358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mholt
reviewed
Sep 30, 2021
u5surf
force-pushed
the
issue-4352
branch
2 times, most recently
from
d031748
to
f3eaa62
Compare
mholt
changed the title
mholt
previously requested changes
Oct 1, 2021
* Add `Accept-Encoding: identity` in virtReq * Add Unit tests for funcHTTPInclude * Change variable name `context` to `tplContext` to use `context` package
It seemed to doubt whether test failed without my changes. But just now, I came up with how to check overwriting Accept-Encoding header with this test. |
francislavoie
approved these changes
Oct 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4352
Add
Accept-Encoding: identityin virtReqAdd Unit tests for funcHTTPInclude
Change variable name
contexttotplContextto usecontextpackageBut I don't know my test implementation is really enough to this fix.
We should make a generic tests or e2e tests about
templatesto check how does it compression or not.I'm not sure how and what to add these tests.