Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

caddytls: Run replacer on ask URL, for env vars #4154

Merged
merged 1 commit into from
May 9, 2021
Merged

caddytls: Run replacer on ask URL, for env vars #4154

merged 1 commit into from
May 9, 2021

Conversation

francislavoie
Copy link
Member

Fixes #3922

@francislavoie francislavoie added this to the 2.x milestone May 8, 2021
@francislavoie francislavoie requested a review from mholt May 8, 2021 22:15
mholt
mholt approved these changes May 9, 2021
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, don't see why not. Thanks!

@mholt mholt merged commit 61642b7 into master May 9, 2021
@mholt mholt deleted the replacer-ask-url branch May 9, 2021 04:37
@francislavoie francislavoie modified the milestones: 2.x, v2.4.0 May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.

Placeholders are not replaced on On-Demand-TLS Ask URL
2 participants
@francislavoie @mholt