Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: Add envfile flag to start command #4141

Merged
merged 6 commits into from
May 2, 2021
Merged

cmd: Add envfile flag to start command #4141

merged 6 commits into from
May 2, 2021

Conversation

jesse996
Copy link
Contributor

add envfile in start cmd

@CLAassistant
Copy link

CLAassistant commented Apr 30, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

mholt
mholt requested changes Apr 30, 2021
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I think it could be even simpler/easier.

cmd/commandfuncs.go Outdated Show resolved Hide resolved
francislavoie
francislavoie requested changes May 1, 2021
View reviewed changes
cmd/commandfuncs.go Show resolved Hide resolved
@francislavoie francislavoie changed the title add envfile in start cmd cmd: Add envfile flag to start command May 1, 2021
@francislavoie francislavoie added this to the v2.4.1 milestone May 1, 2021
mholt
mholt approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

francislavoie
francislavoie approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@francislavoie francislavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch and tried it out, work well! 🎉

@mholt mholt modified the milestones: v2.4.1, v2.4.0 May 2, 2021
@mholt mholt merged commit e6f6d3a into caddyserver:master May 2, 2021
@mholt
Copy link
Member

mholt commented May 2, 2021

Thank you for the contribution @jesse996, and thanks for testing, Francis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francislavoie francislavoie francislavoie approved these changes

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@jesse996 @CLAassistant @mholt @francislavoie