Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd: Use caddy.Log() instead of fmt.Printf for config adapter warnings #4080

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

francislavoie
Copy link
Member

Lines in the logs like this:

2021/03/22 06:11:28.733 INFO    using adjacent Caddyfile
[WARNING][caddyfile] Caddyfile:2: input is not formatted with 'caddy fmt'

Now become:

2021/03/22 06:16:08.734 INFO    using adjacent Caddyfile
2021/03/22 06:16:08.735 WARN    input is not formatted with 'caddy fmt' {"adapter": "caddyfile", "file": "Caddyfile", "line": 2}

Just a bit nicer.

@francislavoie francislavoie added this to the v2.4.0 milestone Mar 22, 2021
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mholt mholt merged commit 911c8a3 into caddyserver:master Mar 29, 2021
@francislavoie francislavoie deleted the config-adapter-logging branch March 29, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants