-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infinite loop on goroutine with http.ResponseController changes #5671
Comments
|
Also noticing some issues now. Very strange -- was not having issues with testing earlier even today. |
Pinging @marten-seemann just in case |
Can you post the stack trace please? |
@marten-seemann It doesn't throw a trace while crashing. I can get it for you; just not sure how at the moment. Also, I checked out commit e198c60 and the server's back functional. Wondering if cd486c2 could be the cause? (@mholt / @francislavoie) Keep in mind that I'm not enabling |
Can you try without Sorry about this 😩 I guess we were a bit hasty with that commit. |
Seems like HTTP/3 isn't related in here, and cd486c2 is indeed the culprit. Must have been a coincidence in my case... @francislavoie Disabling
|
I'm trying to reproduce but I'm having trouble with HTTP/3 locally 😬 why do browsers make it so hard to force HTTP/3 😢 and my usual build of curl https://github.com/yurymuski/curl-http3 doesn't support |
As mentioned, doesn't seem to be related to HTTP/3 - it's crashing for me on HTTP/2 too, my belief of it being related to HTTP/3 was likely something else doing a request to the server at the same time I was doing one too. It's just merely related to compression. |
Oh, well I can't get it to crash with HTTP/2 either. 🤔 |
I have encountered the same issue. Here stacktrace:
|
On HTTP/2 I got a... rather loud stack trace:
|
Ah, @hwilok beat me to it. :) |
I'm also getting this. I don't think it has anything to do with h2 or h3. |
Could any/all of you try out a build with #5672? I still can't reproduce it 😩 but I think that should be the fix. Sorry for the trouble! You can build with |
That was a fast fix - I will try it out and update in here. |
Yep, that seems to be working. No longer crashes for me. |
Thank you! We'll make a v2.7.1 build in the next hour or two. |
LGTM too |
I happens to me when reverse proxing. Maybe that helps to reproduce? Edit: The example Caddyfile in #4314 reproduces the stack overflow. |
Thanks @ueffel, you're right that reproduces it. And I confirmed the fix myself as well. |
Maybe a test I didn't add for #4314 should be considered 😅 |
If you'd like to write a test that'd be great |
Regarding the patch release, maybe wait on the quic-go patch release (see quic-go/quic-go#4012). Will release tomorrow morning. |
Ugh, sorry everyone. I am traveling and have a 100 KBps connection. My laptop is not yet configured with my signing key. Give me a little while to get a new tag pushed. In the meantime I'll merge the fix. @marten-seemann I might still tag ASAP because it's basically broken (somehow tests didn't catch it). Can do a .2 release later though :) |
Ok, 2.7.1 (and now 2.7.2) are released. Thanks for your patience and sorry for the trouble. In the future I will be more judicious about which changes get included right before a release. @marten-seemann Sorry for the noise. Thanks for your attentiveness though 😁 Thank you to everyone who helped while I was traveling today. |
Not sure what happened - I was running
master
on this server for a while, last updated to commit e041962 I believe. I got notified for the Caddy 2.7 release, I re-built it, and nowHTTP/3 fails on this specific server by crashing on the first request it getsit seems to be crashing whenencode
is enabled and the client requests compression.Caddy version is
v2.7.0 h1:ZrAwnBzZ/FBoNw+WBlF2HER8oEs/O7c20ku6nbWFqco=
, running on Fedora 38.Built using Go v1.20.7. (Past working build was on v1.20.6)
The info below is now invalid, as it seems to be unrelated.
(Not sure what's up with my curl there - it eats all the RAM it can until the OOM killer terminates it. On Firefox it stays infinitely loading.)
The config isn't something big, either:
common
is merely this:HTTP/2 seems to be experiencing no crashes, only HTTP/3.
The text was updated successfully, but these errors were encountered: