v2.7.1: websockets randomly work or don't

[ghost]

Neither Caddy nor my web browser seem to provide any insight into this issue. Caddy logs show nothing relevant (perhaps I need to configure something more verbose/debuggy?) and my browser just Eventually™ says it can Never™ connect to wss://whatever after a long period of time.

---

It seems that in v2.7.1 it's totally random whether websockets work for any given reverse_proxy.

For me: neither my Send (ws for file uploads) nor TeslaMate (ws streams in map tiles at vehicle's location in real-time) websockets work. But The Lounge's websockets work fine for me.

For a buddy: his The Lounge's websockets do not work at all.

---

For both of us: Everything works flawlessly upon rolling back to v2.7.0-beta.2 (with the same Caddyfile that doesn't seem to work on v2.7.1). I don't know what change could cause this random behavior.

[francislavoie]

Confirmed, we accidentally broke websockets. Sorry about that. We'll make a v2.7.2 hotfix shortly 😓

[ghost]

Perhaps too many things added to 2.7.0 that should've gone through a beta/RC phase first? 😅

[francislavoie]

Yes. I argued for it but we were too hasty.

[mholt]

We were in beta phase for about a month.

[ouuan]

We were in beta phase for about a month.

I think the "too many things" means the things between beta.2 and the final release.

[ghost]

What @ouuan said.

There were (clearly) too many new changes pushed between 2.7.0-beta.2 and 2.7.0 that never went through any beta lifecycle. Someone would've had to have been building off of master to do the testing.

---

Matt has already acknowledged this: #5671 (comment)

[mholt]

There was precisely 1 commit that I mistakenly thought was ready for release and intended for 2.7, but should have been pushed back for a later patch release.

Still, we're surprised our CI tests didn't catch some of these issues. I'll need to work on our test coverage.