Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: allow overriding OCSP responder #3714

Closed
razonyang opened this issue Sep 8, 2020 · 10 comments
Closed

Feature Request: allow overriding OCSP responder #3714

razonyang opened this issue Sep 8, 2020 · 10 comments
Assignees
Labels
feature ⚙️ New feature or request
Milestone

Comments

@razonyang
Copy link

razonyang commented Sep 8, 2020

Hi, I am getting stuck in OCSP stapling, since ocsp.int-x3.letsencrypt.org is not accessible/reachable from my location(China).

I hope Caddy can provide features similar to Nginx ssl_ocsp_responder for overriding OCSP responder, so that I can set up a proxy for it.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Sep 8, 2020
@francislavoie
Copy link
Member

I think this would need to be implemented in https://github.com/caddyserver/certmagic actually, and if done there, an option would then need to be exposed in Caddy.

@mholt
Copy link
Member

mholt commented Sep 8, 2020

Yep, it'll be implemented in CertMagic then exposed here in Caddy.

Is there ever a reason that the overrides would be per-site? i.e. would configuring a global mapping of OCSP responder -> custom OCSP responder be a good solution?

@mholt mholt added this to the 2.x milestone Sep 8, 2020
@razonyang
Copy link
Author

Nginx supports both of them, it would be nice to have them all.

@mholt
Copy link
Member

mholt commented Sep 9, 2020

@razonyang How does it support both? From what I can see at http://nginx.org/en/docs/http/ngx_http_ssl_module.html#ssl_ocsp_responder, it looks like you just specify a single responder for all certs in that context.

@razonyang
Copy link
Author

@mholt As the documentation mentioned, ssl_ocsp_responder can be placed in http or server context(tested locally).

But overrides OCSP responder globally is good enough for my use case.

@mholt
Copy link
Member

mholt commented Sep 9, 2020

I saw that, but there can be different OCSP servers for different CAs, regardless of the server or site that's being served. That's why I am asking: nginx's implementation doesn't really make sense. It feels like the right way to do this is to map one OCSP server to another, rather than assuming one OCSP server for a whole batch of certificates. And I think that mapping could be global.

@razonyang
Copy link
Author

It seems no more feedback come up. As you said, global mapping is good enough.

@wizicer
Copy link

wizicer commented Dec 29, 2020

I'm suffered from this OCSP timeout issue too, just because my server is located in China.
I just hope the configure reload process could let site online before checking OCSP timeout, at least not sequentially timeout. in my case, my 12 sites configuration need at least 12*30s=6min to available to my visitors.

@mholt
Copy link
Member

mholt commented Jan 7, 2021

I've implemented this in CertMagic, now to expose configuration parameters in Caddy.

@mholt mholt added the in progress 🏃‍♂️ Being actively worked on label Jan 7, 2021
@mholt mholt self-assigned this Jan 7, 2021
@mholt mholt modified the milestones: 2.x, v2.4.0 Jan 7, 2021
mholt added a commit to caddyserver/certmagic that referenced this issue Jan 7, 2021
Allows disabling it entirely, or overriding responder URLs

See caddyserver/caddy#3714
@mholt mholt closed this as completed in 09432ba Jan 7, 2021
@mholt
Copy link
Member

mholt commented Jan 7, 2021

Implemented in 09432ba . To simply disable all OCSP stapling:

{
    ocsp_stapling off
}

will do the trick in the Caddyfile. With JSON config, you can do the same but also override responder URLs by mapping the embedded ones to their replacements. (See code for now; docs will be updated when released.)

@mholt mholt removed the in progress 🏃‍♂️ Being actively worked on label Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ⚙️ New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants