Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compat with NodeNext moduleResolution #142

Merged
merged 1 commit into from
Aug 29, 2022
Merged

Conversation

meteorlxy
Copy link
Contributor

@meteorlxy meteorlxy commented Aug 16, 2022

Without this line, it will throw an error when setting "moduleResolution": "NodeNext" in tsconfig:

error TS7016: Could not find a declaration file for module 'cac'

@codecov-commenter
Copy link

Codecov Report

Merging #142 (d4f3867) into master (ce0f46c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #142   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files           6        6           
  Lines         373      373           
  Branches       89       89           
=======================================
  Hits          245      245           
  Misses        126      126           
  Partials        2        2           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aleclarson
Copy link

@egoist LGTM

@egoist egoist merged commit b8aab4a into cacjs:master Aug 29, 2022
@egoist
Copy link
Collaborator

egoist commented Aug 29, 2022

🎉 This PR is included in version 6.7.13 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants