Improve before
and after
internal logic
#537
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consolidates and improves upon the work in #533 and #536.
before
andafter
from theraw
config, initially added in feat: ordering in hooks. #533. These are not valid pre-commit configuration options and should not be here.before
andafter
from theraw
config.There's nothing to filter out if they're not in the config in the first place. Essentially, reverts bugfix: remove before/after options from config json file #536.
result
field, we now show:id
to the attr name of the hook, instead of thename
. This corrects a mistake made in the module transition (Move to new module structure #397). Technically, a breaking change, but we haven't had feedback from the initial mistake.id
in the options.