hooks: fix rome and nixfmt migrations #515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've decided to go with the "duplicate the thing and move on" migration approach. Here's why: 1. `hooks.nix` doesn't operate at the submodule level. Migrations need to be added to the hooks submodule in `pre-commit.nix`, which is a bit of a mess. 2. `mkAliasOptionModule` and `mkRenamedOptionModule` work (with the above caveat). However, the former makes it impossible AFAIKT to implement warnings because of the two-way aliasing, and the latter will always spew warnings when we eval `enable`. 3. Once we split up `hooks.nix` and have each hook in a separate module, I think we can revisit hook migrations. Until then, the dumb solution is better than a half-baked smart one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to go with the "duplicate the thing and move on" migration approach. Here's why:
hooks.nixdoesn't operate at the submodule level. Migrations need to be added to the hooks submodule inpre-commit.nix, which is a bit of a mess.mkAliasOptionModuleandmkRenamedOptionModulework (with the above caveat). However, the former makes it impossible AFAIKT to implement warnings because of the two-way aliasing, and the latter will always spew warnings when we evalenable.Once we split up
hooks.nixand have each hook in a separate module, I think we can revisit hook migrations. Until then, the dumb solution is better than a half-baked smart one.Fixes #507. Sort of. For now.