Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add hook installation test #423

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Conversation

m1-s
Copy link
Contributor

@m1-s m1-s commented Apr 1, 2024

This PR adds a test that checks that the correct hooks are installed in the hooks directory.

While writing the tests I already discovered and fixed a bug (I think) in this line:

install_stages = lib.unique (cfg.default_stages ++ (builtins.concatLists (lib.mapAttrsToList (_: h: h.stages) enabledHooks)));

This line creates the default stage pre-commit even when stages is manually set to be something else. See the diff for the fix.

This work was started on the #Thaigersprint.

nix/installation-test.nix Outdated Show resolved Hide resolved
@m1-s m1-s force-pushed the installationTest branch 3 times, most recently from b1fe36a to 9ecfb96 Compare April 1, 2024 13:56
@m1-s m1-s force-pushed the installationTest branch 2 times, most recently from 1c7815e to 360e17a Compare April 1, 2024 15:20
@m1-s m1-s force-pushed the installationTest branch from 360e17a to 649fb51 Compare April 1, 2024 15:33
@m1-s
Copy link
Contributor Author

m1-s commented Apr 1, 2024

fixed mac-os pipeline. pls restart workflow.

@domenkozar domenkozar merged commit 642dce0 into cachix:master Apr 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants