-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[question] Can I use this to override a hook while leaving pre-commit-hooks.yaml
alone for my non-nix-using colleagues?
#345
Comments
A more general application of this pattern would be to override cases like this:
So that you can map them to declared environments, rather than using whatever pre-commit comes up with for "system" |
Has anyone found a solution for this already? I don't want to necessarily overwrite, but at least keep the existing .pre-commit-hook.yaml for non-nix collaborators |
It's currently hardcoded, but I suppose with some hacking (on this repo) the location could be turned into an option git-hooks.nix/modules/pre-commit.nix Line 62 in 8d6a17d
I think you can pass an alternate config location to pre-commit as well. |
This fixes cachix#345, by adding a `configFile` option to change the default (`.pre-commit-config.yaml`) and so enables the parallel usage of devenv and non-devenv maintained pre-commit hooks.
This fixes cachix#345, by adding a `configFile` option to change the default (`.pre-commit-config.yaml`) and so enables the parallel usage of devenv and non-devenv maintained pre-commit hooks.
I see that there is already an issue for documenting how to "override" a hook. I also want to override a hook, but I think we mean "override" in different ways.
Most of my team doesn't use nix, so they run pre-commit against a
.pre-commit-hooks.yaml
which I would be frowned at if I deleted and.gitignored
as this warning recommends:I maintain a flake.nix in my team's repo because I appreciate the determinism, especially when switching between machines. This comes with certain headaches like this one. Since
charliermarsh/ruff-pre-commit
breaks on NixOS but works for my non-nix coworkers, I'd like to do the following.A: contribute a
ruff
pre-commit hook to pre-commit-hooks.nixB: configure pre-commit-hooks.nix to run the nix-friendly hook instead of
charliermarsh/ruff-pre-commit
, but otherwise conform to the existing hooksC: commit this configuration to my repo in a way that does not break my non-nix coworker's workflows
So when I say "override" I mean:
Can I get some advice on whether pre-commit-hooks.nix is capable of supporting B and C? If so, how would I configure it?
The text was updated successfully, but these errors were encountered: