-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add opentelemetry example #31
chore: add opentelemetry example #31
Conversation
474c12d
to
ceef58e
Compare
Regarding the instrumentation, I've noticed 2 things:
@tillkruss I can try to address both issues, but wanted to check with you first. |
Good catch, feel free to add both. The db.statement could be extremely massive. I read somewhere that values should be omitted, just keys should be logged. |
ceef58e
to
1ac06f0
Compare
I've sent #32 to record
That recommendation only applies for span names. Attributes can be arbitrary large, for example, it is a common practice to record SQL queries which can be much larger than Redis commands. |
Relay works just like PhpRedis for transactions: https://github.com/phpredis/phpredis |
I've done the |
1ac06f0
to
9c3ba46
Compare
I will continue working on this, but it is a decent preview of how it will look.