Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added german lang File #133

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from
Draft

Added german lang File #133

wants to merge 13 commits into from

Conversation

driverspy
Copy link

Hi! I added a German translation.
Since I noticed that you prefer to focus on English translations at the moment, the pull request can be marked as a draft.

Let me know if you want any adjustments.

@jbrooksuk
Copy link
Member

Thanks for this! We'll keep it in draft for now.

@jbrooksuk
Copy link
Member

Thanks for keeping on top of this, @driverspy!

As an aside, I'm wondering, should Cachet switch to the PHP translation files instead?

@driverspy
Copy link
Author

Hey @jbrooksuk,

Unfortunately I can't answer your question. I'm pretty sure I can translate into PHP too :P

@jbrooksuk
Copy link
Member

Sorry to be a huge pain, @driverspy, but I've just merged in #162 which converts Cachet's translations files to use short keys. I appreciate this is a pain, but:

  1. @danjohnson95 took the time to localize all strings within Cachet.
  2. Using short keys allows us to provide context to individual translations throughout the application.

I'd really appreciate your support in updating your PR 🫶

@driverspy
Copy link
Author

Hey, no problem, I'll translate it again.

Fortunately, it wasn't that much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants