Do not enclose env vars with double quotes #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was making some configuration ending with something like MAIL_USERNAME="null", instead of MAIL_USERNAME=null
Do not enclose some env values with double quotes
|
Hmm this seems related to #61 - I wish we had a test for this 🤔 |
|
Hmm.. Ping @GrahamCampbell for this. |
|
Blindly putting everything in double quotes is a bad idea, since it doesn't work. Only things that need quoting should be quoted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was making some configuration ending with something like MAIL_USERNAME="null", instead of MAIL_USERNAME=null