-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch docker-compose.yml to use pgsql #11
Conversation
ping @cachethq/docker |
@rtrauntvein so what exactly do you want and why do you change to pgsql |
Just looking for review of the PR. This is based on suggestion of using Postgres instead of MySQL by @GrahamCampbell or @jbrooksuk |
Because it's way better than mysql. ;P |
it is less popular , according to http://db-engines.com/en/ranking |
Doesn't mean it's not better. |
In our experience - with StyleCI - MySQL has a lot of quirks that we can avoid. |
i would quote Donald E. Knuth here, "premature optimization is root of all evil". If your users demand this - fine. If it solves some problem that already exists in Cachet - also fine. If this to show off your personal taste - you're on your own :) |
@rtrauntvein as for PR itself - why did you change data-only container to the folder on host machine? |
There was no data volume or data only container for persistence of the Database before. Sent from my iPhone
|
@rtrauntvein you are right, no volumes for compose. You just hardcoded the path on host machine, that this "compose" script will demand. |
The directory would get created automatically, but I will just take it out. |
Any news on this? |
Switch docker-compose.yml to use pgsql
Change to
docker-compose.yml
to utilize postgresql instead of MySQL. Does not require immediately updating docs, since MySQL will still work fine also.Closes #2