Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Glyphs #639

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Feat: Glyphs #639

merged 1 commit into from
Mar 17, 2023

Conversation

dark0dave
Copy link
Contributor

@dark0dave dark0dave commented Mar 6, 2022

Fix glyphs to use regular charcode.

From
#499
#483

@cabarius
Copy link
Owner

cabarius commented Mar 8, 2022

Can you please implement these as optional with a toggle in the settings tab. Please make the default be the current ones and define these as "Use Compatibility Glyphs (for Linux, etc)"

@cabarius
Copy link
Owner

cabarius commented Mar 8, 2022

Sorry I didn't read this carefully to see that you implemented my request already. Looking more carefully.

Copy link
Owner

@cabarius cabarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good in general. Please consider the UI feedback and after that I'll merge this. Please forgive my slow response. I am still traveling for another 2 weeks or so.

Signed-off-by: dark0dave <[email protected]>
@dark0dave
Copy link
Contributor Author

@cabarius no worries. I have updated the pr.

@dark0dave dark0dave requested a review from cabarius March 16, 2022 21:11
@cabarius cabarius merged commit de1c5f1 into cabarius:master Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants