Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deemphasize seeders in peer name list UI #51

Open
nikolaiwarner opened this issue Aug 7, 2018 · 8 comments
Open

Deemphasize seeders in peer name list UI #51

nikolaiwarner opened this issue Aug 7, 2018 · 8 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@nikolaiwarner
Copy link
Member

If there is a way to tell if connected peers are seeders, it would be nice to change the color of their nick or place them at the end of the list so that real user nicks are more prominent.

@hackergrrl
Copy link
Member

hackergrrl commented Aug 7, 2018 via email

@hackergrrl
Copy link
Member

hackergrrl commented Aug 7, 2018 via email

@nikolaiwarner
Copy link
Member Author

Yeah! I'm not interested in seeing seeder's names though. But I really care about who's online at the moment. I think it would be really cool to just show a count of the seeders to give the user some confidence. Then in another screen, show a named list of seeders and also their uptime.

It also would be interesting if there was an indicator shown when coming back online telling you that there were no seeders around when you were gone... to give you a clue that there may be gaps in your history.

@hackergrrl
Copy link
Member

hackergrrl commented Aug 8, 2018 via email

@nikolaiwarner
Copy link
Member Author

That's a great point! I'm with you.

What about showing an icon or symbol along with the name indicating if a peer is a seeder or regular peer?

I suppose my real goal here is inform the user if another peer has a human behind it who can respond. A set of symbols could also be useful to identify bots when we get to that 🤖

@hackergrrl
Copy link
Member

hackergrrl commented Aug 8, 2018 via email

@cblgh
Copy link
Member

cblgh commented Aug 8, 2018 via email

@hackergrrl hackergrrl added enhancement New feature or request help wanted Extra attention is needed labels Apr 8, 2020
@hackergrrl
Copy link
Member

hackergrrl commented Apr 8, 2020

If anyone is interested in working on this, I'd be happy to help mentor! Here's the TODOs I see:

  • in cabal-cli, pass argv.seed into cabal-client
  • in cabal-client, pass that seed variable into cabal.swarm()
  • in cabal-core, edit the initial handshake hypercore extension to include whether the peer is a seed
  • in cabal-core, edit the _addConnection() function to accept something like opts.isSeed and emit that in the peer-added event
  • back into cabal-client, edit that event listener in src/cabal-details.js to set something like user.seed = true if it's a seeding peer
  • back into cabal-cli, edit views.js's renderNicks function to check for user.seed and render a sigil next to their name
  • bonus: sort seeds to the bottom of the online peers list! this is in util.js's cmpUser

At a high level, it's

  1. thread the --seed argument down to cabal-core, and then
  2. thread the user.seed property back up the stack to the frontend so it can be displayed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants