Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean repo #31

Merged
merged 11 commits into from
Dec 9, 2024
Merged

chore: clean repo #31

merged 11 commits into from
Dec 9, 2024

Conversation

JTaeuber
Copy link
Member

@JTaeuber JTaeuber commented Dec 9, 2024

Motivation

I started doing a little cleanup like in caas-team/py-kube-downscaler#112.

Changes

  • Made pre-commit config usable
  • Removed not needed files
  • Formatted files
  • Adjusted a few parameters
  • Bumped version number for new release

Tests done

pre-commit and pytest pass

TODO

  • I've assigned myself to this PR

Copy link

github-actions bot commented Dec 9, 2024

File Coverage
All files 99%
__init__.py 100%
test_api.py 100%
test_config.py 98%
test_console.py 100%
test_http.py 100%
test_httpclient.py 100%
test_objects.py 100%
test_query.py 100%
test_session.py 100%
test_utils.py 100%
test_watch.py 100%

Minimum allowed coverage is 70%

Generated by 🐒 cobertura-action against 4d4c029

Copy link
Member

@jonathan-mayer jonathan-mayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFineTM

@Fovty
Copy link
Member

Fovty commented Dec 9, 2024

@JTaeuber We should bump the python version in the workflows too (similar to this), and maybe also the classifiers in pyproject.toml

Copy link
Member

@Fovty Fovty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest looks fine

@JTaeuber
Copy link
Member Author

JTaeuber commented Dec 9, 2024

forgot about the worflows, good call 👍

@JTaeuber
Copy link
Member Author

JTaeuber commented Dec 9, 2024

you mean to change the classifiers like this then?

@JTaeuber JTaeuber requested a review from Fovty December 9, 2024 09:38
@Fovty
Copy link
Member

Fovty commented Dec 9, 2024

Yeah, exactly, will look clean on pypi then

Copy link
Member

@Fovty Fovty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@JTaeuber JTaeuber merged commit 89fcf08 into main Dec 9, 2024
5 checks passed
@JTaeuber JTaeuber deleted the Chore/CleanRepo branch December 9, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants