-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/rancher performance #34
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Bressi <[email protected]>
The dependencies are already updated, no need to run the command again.
The pinning of the images practically blocked the update of most components.
Signed-off-by: Bruno Bressi <[email protected]>
This commit adds the necessary templates to be able to parse the rancher deployments metrics. The resources were copied from the official rancher-monitoring chart. The default behavior should be not to activate this monitoring, because the chart is typically deployed in downstream clusters, which don't have any rancher deployments.
puffitos
added
bug
Something isn't working
area/dashboards
Issues and PRs regarding the grafana dashboards shipped with the chart.
labels
Jan 22, 2025
Merged
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
JTaeuber
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/dashboards
Issues and PRs regarding the grafana dashboards shipped with the chart.
bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #32 . Review after #33
Changes
Added the official solution on how to parse the metrics from the rancher deployment, by adding an "exporter" to the templates.
Tests done
Tested in a CaaS development cluster. After waiting for around 15, the panels in the dashboard are populated:
I've no idea ATM why the session transmit error is empty. The metrics are there:
It's probably a network problem in the cluster 🤷