Chore/fix ingress dashboards #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CRDs were still present in the chart. Now they are not Signed-off-by: Bruno Bressi <[email protected]>
This shouldn't be needed to make the chart
No more experimental flags and use make directly to create the chart
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Source of dasbhoards is the official repo: https://github.com/kubernetes/ingress-nginx/tree/main/deploy/grafana/dashboards Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
CerRegulus
approved these changes
Jan 3, 2025
y-eight
approved these changes
Jan 3, 2025
puffitos
added
the
area/dashboards
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of resolving #17
Changes done
Tests done
Tested in caas developement cluster. The dashboards look like this now:
Old dashboards (sorry, no data available):
I've added another commit to rename the "Request Handling Performance" dashboard to "NGINX Request Handling Performance", to match the naming of the other NGINX dashboard we're offering. The tags are still present for the dashboard by the file-like structured naming was dropped.