Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/really remove crds #16

Merged
merged 5 commits into from
Jan 2, 2025
Merged

Chore/really remove crds #16

merged 5 commits into from
Jan 2, 2025

Conversation

puffitos
Copy link
Member

@puffitos puffitos commented Jan 2, 2025

Motivation

Resolves #15 - the chart still had the CRDs in them and we don't really need them.

❯ ll
total 3.9M
-rw-r--r-- 1 bbressi bbressi 1.1M Jan  2 16:05 caas-cluster-monitoring-0.0.13.tgz
-rw-r--r-- 1 bbressi bbressi 478K Jan  2 15:52 caas-cluster-monitoring-0.0.14-rc0.tgz

Changes

  • Expanded the hack script to actually also remove the dependency of the kube-prometheus-stack to its crds subchart
  • Long overdue cleanup on the helm release job
  • version bump to 14-rc0 (will make multiple releases until we hit 1.0.0)

Tests done

Version has been deployed in the caas development clusters without any side effects.

puffitos and others added 5 commits November 13, 2024 19:29
@puffitos
chore: remove the crds entirely
c87aa26 
The CRDs were still present in the chart. Now they are not

Signed-off-by: Bruno Bressi <[email protected]>
@puffitos
chore: removed prometheus tarball from repo
809fa75 
This shouldn't be needed to make the chart
@puffitos
chore: github action cleanup
6ed62cd 
No more experimental flags and use make directly to create the chart
@puffitos
chore: 0.0.14rc0
716c55b
@puffitos
chore: removed tarball for real
365e0c0 
Signed-off-by: Bruno Bressi <[email protected]>
@puffitos puffitos self-assigned this Jan 2, 2025
@puffitos puffitos added this to the 1.0.0 milestone Jan 2, 2025
@puffitos puffitos merged commit e963408 into main Jan 2, 2025
3 checks passed
@puffitos puffitos deleted the chore/really-remove-crds branch January 2, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@y-eight y-eight y-eight approved these changes

@eumel8 eumel8 Awaiting requested review from eumel8

@JTaeuber JTaeuber Awaiting requested review from JTaeuber

@CerRegulus CerRegulus Awaiting requested review from CerRegulus

Assignees

@puffitos puffitos

Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

Uneeded files in repository
2 participants
@puffitos @y-eight