Bump to prom auth 0.6.0 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bruno Bressi <[email protected]>
The prometheus auth specification was being overwritten for all caas clusters with those values. To simplify our deployment and maintainance, we move those values here. Any other user can freely edit the chart to change the resources, as they may well please. Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Signed-off-by: Bruno Bressi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of getting rid of the non-existent API Group monitoring.cattle.io, which is bound to the prometheus auth mechanism. This new release (0.0.13) just includes the new prometheus auth, which deprecates the old group.
The next version of caas-cluster-monitoring and prometheus-auth will be incompatible with previous versions and remove the API group completely.
Tests done
Tested in our staging environment was done. Cluster & Project monitoring work as intended. See internal caas-cluster-monitoring Issue 17 for more.