Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for using custom whois host per domain #180

Merged
merged 2 commits into from
Apr 11, 2023
Merged

add support for using custom whois host per domain #180

merged 2 commits into from
Apr 11, 2023

Conversation

serhatcetinkaya
Copy link
Contributor

Description

intended as a fix for #92

Details

this doesn't break backwards compatibility. we can still continue using it with old config but with this patch we have the opportunity to specify whois host per domain in special cases, like:

domains:
- name: google.com
- name: facebook.com
- name: some.other.domain.with.special.whois.host
  host: whois.godaddy.com

@caarlos0
Copy link
Owner

caarlos0 commented Apr 5, 2023

I think we can probably do the breaking change and bump major...

or, we could do something like:

whois:
  - tlds: [ 'is', 'de' ]
    host: whois.godaddy.com

domains:
  - keep.as.is
  - google.de
  - foo.com

assuming my assumption that when you need to set a custom whois server, it usually is needed for the entire tld

@serhatcetinkaya
Copy link
Contributor Author

@caarlos0 hello, that looks neat. but I suppose it will not work for all cases. for example let's say I have 2 domains with .es tld, one purchased from godaddy second from uniregistry. for one of them whois.godaddy.com will work, the other will get error and we might need to define a different host for it.

what do you think?

@caarlos0
Copy link
Owner

caarlos0 commented Apr 7, 2023

ah, that makes sense...

@caarlos0 caarlos0 merged commit 05e98cc into caarlos0:main Apr 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants