Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #10127 #10132

Closed
wants to merge 1 commit into from
Closed

Issue #10127 #10132

wants to merge 1 commit into from

Conversation

Player256
Copy link

dippindots
dippindots approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@dippindots dippindots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, @Player256 thanks for fixing this!

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@JREastonMarks
Copy link
Contributor

Hi @Player256,
Thank you for the PR. We have moved all the code in the core module to a new repo here: https://github.com/cBioPortal/cbioportal-core

I am going to close this ticket. Feel free to recreate the PR in the core repository.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dippindots dippindots dippindots approved these changes

Assignees
No one assigned
Labels
validator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rejects count is incorrect when variant_classification_filter is set to blank value
4 participants
@Player256 @JREastonMarks @dippindots @Player255