Bugfix/hide empty tab #4969
Open
Bugfix/hide empty tab #4969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Nelliney
force-pushed
the
bugfix/hide-empty-tab
branch
from
232c3e8
to
e41c49e
Compare
Nelliney
requested review from
alisman and
inodb
and removed request for
alisman
inodb
reviewed
Aug 20, 2024
There was a problem hiding this comment.
@Nelliney @alisman is one option to do something like this:
if (resourceURL) {
if (resourceDataExists) {
// show data in tab
} else {
// show tab and show text "No {tabName} for this patient".
}
} else {
if (resourceDataExists) {
// show tab
} else {
// hide tab
}
}
I.e. show a message when in the URL the tab is explicitly requested, but hide the tab in other scenarios. It currently feels a bit odd that it jumps back to the "Summary View" when the patient does not have the requested tab
Nelliney
force-pushed
the
bugfix/hide-empty-tab
branch
from
593846a
to
fb4854d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug: in the patient view, when selecting the 'Files and Links' tab and navigating through patients, an empty tab was shown for those without data (see link). This fix ensures that the 'Files & Links' tab will display "There are no results" for patients who don't have any data.
Before the fix:
After the fix: