Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [binance] add new margin order side effect AUTO_BORROW_REPAY #1711

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

lanphan
Copy link
Contributor

@lanphan lanphan commented Aug 25, 2024

@bbgokarma-bot
Copy link

Welcome back! @lanphan, This pull request may get 210 BBG.

Copy link

codecov bot commented Aug 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 24.19%. Comparing base (b88aff6) to head (9a7517a).
Report is 88 commits behind head on main.

Files Patch % Lines
pkg/types/order.go 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1711      +/-   ##
==========================================
+ Coverage   22.91%   24.19%   +1.28%     
==========================================
  Files         606      611       +5     
  Lines       45003    36999    -8004     
==========================================
- Hits        10311     8952    -1359     
+ Misses      33940    27254    -6686     
- Partials      752      793      +41     
Files Coverage Δ
pkg/types/order.go 1.45% <0.00%> (-0.24%) ⬇️

... and 523 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ad80f...9a7517a. Read the comment docs.

@c9s c9s changed the title add new sideeffect AUTO_BORROW_REPAY FEATURE: [binance] add new margin order side effect AUTO_BORROW_REPAY Aug 26, 2024
@c9s c9s merged commit 90bcd25 into c9s:main Aug 26, 2024
4 of 5 checks passed
@bbgokarma-bot
Copy link

Hi @lanphan,

Well done! 220 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x225fd8d20521627acbf4b608c73f6f8d75607f7b01ed58eeb07fc7560cee1d9d

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants