FEATURE: [dca2] make the take-profit order of round from order to orders #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbearXD
force-pushed
the
kbearXD/dca2/flexible-recovery
branch
from
64280e8
to
1d0b4e5
Compare
c9s
reviewed
Jun 13, 2024
pkg/strategy/dca2/collector.go
Outdated
| if order.Status != types.OrderStatusFilled { | ||
| rc.logger.Infof("take-profit order is %s not filled, so this round is not finished. Skip it", order.Status) | ||
| rc.logger.Infof("take-profit order is %s not filled, so this round is not finished. Keep collecting", order.Status) |
c9s
reviewed
Jun 13, 2024
pkg/strategy/dca2/collector.go
Outdated
| for _, o := range round.TakeProfitOrders { | ||
| if types.IsActiveOrder(o) { | ||
| // Should not happen ! but we only log it | ||
| rc.logger.Errorf("there is at least one take-profit order (%d) is still active, please check it", o.OrderID) |
There was a problem hiding this comment.
you can add prefix "unexpected error"
There was a problem hiding this comment.
and maybe print the symbol and the order? would prefer using #{orderID} format
c9s
approved these changes
Jun 13, 2024
kbearXD
force-pushed
the
kbearXD/dca2/flexible-recovery
branch
from
8415678
to
60160cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.