Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE:[indicator] add adx indicator #1604

Merged
merged 5 commits into from
Mar 26, 2024
Merged

FEATURE:[indicator] add adx indicator #1604

merged 5 commits into from
Mar 26, 2024

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented Mar 23, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @anywhy,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 359 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLAassistant commented Mar 23, 2024

CLA assistant check
All committers have signed the CLA.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 369 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 374 BBG

Copy link

codecov bot commented Mar 23, 2024

Codecov Report

Attention: Patch coverage is 89.79592% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 22.65%. Comparing base (d58461d) to head (88281c1).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
+ Coverage   22.59%   22.65%   +0.05%     
==========================================
  Files         619      620       +1     
  Lines       44830    44881      +51     
==========================================
+ Hits        10130    10166      +36     
- Misses      33973    33986      +13     
- Partials      727      729       +2     
Files Coverage Δ
pkg/bbgo/indicator_set.go 46.42% <0.00%> (-1.72%) ⬇️
pkg/indicator/v2/adx.go 93.61% <93.61%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d58461d...88281c1. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 384 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 398 BBG

@c9s
Copy link
Owner

c9s commented Mar 26, 2024

awesome, thanks!

@c9s c9s merged commit 6ac642b into c9s:main Mar 26, 2024
5 checks passed
@lanphan lanphan mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants