Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [xalign] add more complex test case for xalign strategy #1593

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

c9s
Copy link
Owner

@c9s c9s commented Mar 19, 2024

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 454 BBG.

Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 22.59%. Comparing base (3e14c14) to head (aced149).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1593      +/-   ##
==========================================
+ Coverage   22.53%   22.59%   +0.06%     
==========================================
  Files         618      619       +1     
  Lines       44528    44830     +302     
==========================================
+ Hits        10034    10130      +96     
- Misses      33779    33973     +194     
- Partials      715      727      +12     
Files Coverage Δ
pkg/bbgo/session.go 8.22% <0.00%> (-0.03%) ⬇️
pkg/strategy/xalign/strategy.go 33.80% <71.42%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e14c14...aced149. Read the comment docs.

@c9s c9s requested a review from kbearXD March 19, 2024 07:53
@c9s c9s merged commit d58461d into main Mar 19, 2024
5 checks passed
@c9s c9s deleted the c9s/xalign-add-test-cases branch March 19, 2024 08:07
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 464 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x990b0971cc41a05cc2cd6a2ffbea25efbd0ff12a5652d41d519b5d0e4e255637

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants