Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Restore parameters when update active order book #1582

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented Mar 14, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @anywhy,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 209 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 22.41%. Comparing base (3a98660) to head (a26f489).
Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1582      +/-   ##
==========================================
+ Coverage   22.40%   22.41%   +0.01%     
==========================================
  Files         615      616       +1     
  Lines       44436    44463      +27     
==========================================
+ Hits         9954     9966      +12     
- Misses      33772    33787      +15     
  Partials      710      710              
Files Coverage Δ
pkg/bbgo/activeorderbook.go 28.11% <100.00%> (+3.19%) ⬆️

... and 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a98660...a26f489. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 277 BBG

Copy link
Owner

@c9s c9s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is great, thanks

@c9s c9s merged commit e621938 into c9s:main Mar 18, 2024
5 checks passed
@anywhy anywhy deleted the fix_marketactiveorders branch March 19, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants