Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINOR: [okx][bitget] remove the query after place order #1581

Merged

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 446 BBG.

@bailantaotao bailantaotao force-pushed the edwin/bybit/return-order-directly-after-placing-the-order branch from 5cd5e29 to d75e7eb Compare March 14, 2024 04:15
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 445 BBG

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 44.82759% with 16 lines in your changes are missing coverage. Please review.

Project coverage is 22.40%. Comparing base (747b75f) to head (d75e7eb).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1581      +/-   ##
==========================================
- Coverage   22.44%   22.40%   -0.05%     
==========================================
  Files         615      615              
  Lines       44463    44436      -27     
==========================================
- Hits         9981     9954      -27     
- Misses      33770    33772       +2     
+ Partials      712      710       -2     
Files Coverage Δ
pkg/exchange/bitget/convert.go 93.49% <ø> (+0.45%) ⬆️
pkg/exchange/bitget/exchange.go 79.89% <92.85%> (+0.45%) ⬆️
pkg/exchange/bybit/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 747b75f...d75e7eb. Read the comment docs.

@bailantaotao bailantaotao merged commit 3a98660 into main Mar 14, 2024
5 checks passed
@bailantaotao bailantaotao deleted the edwin/bybit/return-order-directly-after-placing-the-order branch March 14, 2024 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants