Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [okx] remove the query after place order #1578

Merged
merged 1 commit into from
Mar 13, 2024

Conversation

bailantaotao
Copy link
Collaborator

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 211 BBG.

return nil, fmt.Errorf("failed to parse response order id: %w", err)
}

timeNow := time.Now()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We specify the time after the network operation, which can take seconds or longer. Running time.Now() upon entering this method would yield a more accurate timestamp

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 22.31%. Comparing base (8197dbd) to head (2904759).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1578      +/-   ##
==========================================
- Coverage   22.31%   22.31%   -0.01%     
==========================================
  Files         615      615              
  Lines       44457    44463       +6     
==========================================
  Hits         9921     9921              
- Misses      33830    33836       +6     
  Partials      706      706              
Files Coverage Δ
pkg/exchange/okex/exchange.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8197dbd...2904759. Read the comment docs.

@bailantaotao bailantaotao force-pushed the edwin/rm-query-order-after-place-order branch from 89d8ca5 to 2904759 Compare March 13, 2024 06:54
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 231 BBG

@bailantaotao bailantaotao merged commit 2a7d470 into main Mar 13, 2024
3 of 5 checks passed
@bailantaotao bailantaotao deleted the edwin/rm-query-order-after-place-order branch March 13, 2024 07:34
@bbgokarma-bot
Copy link

Hi @bailantaotao,

Well done! 236 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x57efb51c13f04bbad4105ac8f1b8b69e69aa12f575242c05a80dfd8c5ea5863e

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants