-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: [okx] remove the query after place order #1578
Conversation
Welcome back! @bailantaotao, This pull request may get 211 BBG. |
pkg/exchange/okex/exchange.go
Outdated
return nil, fmt.Errorf("failed to parse response order id: %w", err) | ||
} | ||
|
||
timeNow := time.Now() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We specify the time after the network operation, which can take seconds or longer. Running time.Now() upon entering this method would yield a more accurate timestamp
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
- Coverage 22.31% 22.31% -0.01%
==========================================
Files 615 615
Lines 44457 44463 +6
==========================================
Hits 9921 9921
- Misses 33830 33836 +6
Partials 706 706
Continue to review full report in Codecov by Sentry.
|
89d8ca5
to
2904759
Compare
Re-estimated karma: this pull request may get 231 BBG |
Hi @bailantaotao, Well done! 236 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x57efb51c13f04bbad4105ac8f1b8b69e69aa12f575242c05a80dfd8c5ea5863e Thank you for your contribution! |
No description provided.