Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [exit] Use configuration instead of kine fixed interval #1549

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

anywhy
Copy link
Contributor

@anywhy anywhy commented Feb 28, 2024

No description provided.

@bbgokarma-bot
Copy link

Hi @anywhy,

This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development.

This pull request may get 226 BBG.

To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:

polygon:0xAb5801a7D398351b8bE11C439e05C5B3259aeC9B

Once this pull request is merged, your BBG tokens will be transferred to your wallet.

--
If you're interested in our project, feel free to join our Telegram group https://t.me/bbgo_intl

Best,
KarmaBot

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@@ -30,15 +30,19 @@ type ProtectiveStopLoss struct {
// PlaceStopOrder places the stop order on exchange and lock the balance
PlaceStopOrder bool `json:"placeStopOrder"`

// Interval is the time resolution to update the stop order
// KLine per Interval will be used for updating the stop order
Interval types.Interval `json:"interval,omitempty"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you set the default value to 1m if it’s empty?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 246 BBG

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 21.66%. Comparing base (4f57c5b) to head (2567bd0).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1549      +/-   ##
==========================================
- Coverage   21.66%   21.66%   -0.01%     
==========================================
  Files         607      607              
  Lines       44048    44058      +10     
==========================================
  Hits         9543     9543              
- Misses      33823    33833      +10     
  Partials      682      682              
Files Coverage Δ
pkg/bbgo/exit_trailing_stop.go 52.58% <0.00%> (-0.93%) ⬇️
pkg/bbgo/exit_protective_stop_loss.go 0.00% <0.00%> (ø)
pkg/bbgo/exit_roi_take_profit.go 0.00% <0.00%> (ø)
pkg/bbgo/exit_roi_stop_loss.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f57c5b...2567bd0. Read the comment docs.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 283 BBG

@anywhy anywhy requested a review from c9s March 4, 2024 13:19
@c9s c9s merged commit ca5f31b into c9s:main Mar 4, 2024
2 of 5 checks passed
@c9s
Copy link
Owner

c9s commented Mar 4, 2024

nvm, i used administrator mode to merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants