-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: [exit] Use configuration instead of kine fixed interval #1549
Conversation
Hi @anywhy, This is KarmaBot, and we reward your contributions with tokens sent directly to your wallet to support development. This pull request may get 226 BBG. To receive BBG tokens, please provide your Polygon (can be Ethereum) address as an issue comment in this pull request, following this format:
Once this pull request is merged, your BBG tokens will be transferred to your wallet. -- Best, |
root seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
@@ -30,15 +30,19 @@ type ProtectiveStopLoss struct { | |||
// PlaceStopOrder places the stop order on exchange and lock the balance | |||
PlaceStopOrder bool `json:"placeStopOrder"` | |||
|
|||
// Interval is the time resolution to update the stop order | |||
// KLine per Interval will be used for updating the stop order | |||
Interval types.Interval `json:"interval,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you set the default value to 1m if it’s empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok
2647815
to
1517226
Compare
Re-estimated karma: this pull request may get 246 BBG |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1549 +/- ##
==========================================
- Coverage 21.66% 21.66% -0.01%
==========================================
Files 607 607
Lines 44048 44058 +10
==========================================
Hits 9543 9543
- Misses 33823 33833 +10
Partials 682 682
Continue to review full report in Codecov by Sentry.
|
Re-estimated karma: this pull request may get 283 BBG |
@anywhy i have approve it, you need to fix the cla signing :-) |
nvm, i used administrator mode to merge it |
No description provided.