-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEATURE: [binance] add margin request #1525
Conversation
bailantaotao
commented
Feb 5, 2024
- The go-binance library has been deprecated, so I added a new margin request.
- We don't need the timestamp because the value is initialized in client.go
Welcome back! @bailantaotao, This pull request may get 547 BBG. |
// Only for Isolated margin | ||
symbol *string `param:"symbol"` | ||
|
||
amount string `param:"amount"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use fixedpoint value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK.
The previous type is because I simply copied the value from another file.
The caller uses req.Price(order.Market.FormatPrice(order.Price))
Re-estimated karma: this pull request may get 566 BBG |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1525 +/- ##
==========================================
- Coverage 21.78% 21.77% -0.01%
==========================================
Files 604 605 +1
Lines 43885 43885
==========================================
- Hits 9559 9558 -1
- Misses 33643 33645 +2
+ Partials 683 682 -1
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Hi @bailantaotao, Well done! 586 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x7db8954514e78cfd844526584595c41bbf2ccdc36fccc6874c6cac8b920095cd Thank you for your contribution! |