Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE: [okx] add new kline stream #1514

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

bailantaotao
Copy link
Collaborator

I will add the usage in the next PR.

@bbgokarma-bot
Copy link

Welcome back! @bailantaotao, This pull request may get 338 BBG.

@CLAassistant
Copy link

CLAassistant commented Jan 26, 2024

CLA assistant check
All committers have signed the CLA.

@bailantaotao bailantaotao force-pushed the edwin/okx/refactor-kline-api branch 4 times, most recently from f13c17e to d2b45f5 Compare January 29, 2024 12:59
Base automatically changed from edwin/okx/refactor-kline-api to main January 30, 2024 01:33
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 348 BBG

Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 63 lines in your changes are missing coverage. Please review.

Comparison is base (2d3f8fb) 21.82% compared to head (4290369) 21.79%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1514      +/-   ##
==========================================
- Coverage   21.82%   21.79%   -0.03%     
==========================================
  Files         603      605       +2     
  Lines       43799    43851      +52     
==========================================
  Hits         9557     9557              
- Misses      33560    33612      +52     
  Partials      682      682              
Files Coverage Δ
pkg/exchange/okex/okexapi/client.go 11.30% <ø> (ø)
pkg/exchange/okex/stream.go 0.00% <0.00%> (ø)
pkg/exchange/okex/klinestream_callbacks.go 0.00% <0.00%> (ø)
pkg/exchange/okex/kline_stream.go 0.00% <0.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d3f8fb...4290369. Read the comment docs.

@bailantaotao bailantaotao merged commit e3208b3 into main Jan 30, 2024
3 of 5 checks passed
@bailantaotao bailantaotao deleted the edwin/okx/candle-event branch January 30, 2024 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants