Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: [grid2] add remove duplicated pins and pull out filter price prec func #1239

Merged
merged 3 commits into from
Jul 23, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jul 22, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 282 BBG.

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 293 BBG

@codecov
Copy link

codecov bot commented Jul 22, 2023

Codecov Report

❗ No coverage uploaded for pull request base (v1.50@bded2ed). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             v1.50    #1239   +/-   ##
========================================
  Coverage         ?   21.03%           
========================================
  Files            ?      509           
  Lines            ?    35179           
  Branches         ?        0           
========================================
  Hits             ?     7399           
  Misses           ?    27233           
  Partials         ?      547           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bded2ed...aac2884. Read the comment docs.

@c9s c9s requested review from ycdesu and narumiruna July 22, 2023 05:09
p := fixedpoint.Value(pin)

if _, exists := buckets[p.String()]; exists {
continue
Copy link
Collaborator

@gx578007 gx578007 Jul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth logging errors if any duplicated pin is found.

@c9s c9s merged commit 3da7eb0 into v1.50 Jul 23, 2023
@c9s c9s deleted the c0s/grid2-remove-duplicated-pins branch July 23, 2023 07:28
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 313 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0x8c681b632ba940123c65c1d650677338a670cb8f447925c5eec98207bf4d7355

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants