-
-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: [grid2] add remove duplicated pins and pull out filter price prec func #1239
Conversation
Welcome back! @c9s, This pull request may get 282 BBG. |
Re-estimated karma: this pull request may get 293 BBG |
Codecov Report
@@ Coverage Diff @@
## v1.50 #1239 +/- ##
========================================
Coverage ? 21.03%
========================================
Files ? 509
Lines ? 35179
Branches ? 0
========================================
Hits ? 7399
Misses ? 27233
Partials ? 547 Continue to review full report in Codecov by Sentry.
|
p := fixedpoint.Value(pin) | ||
|
||
if _, exists := buckets[p.String()]; exists { | ||
continue |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be worth logging errors if any duplicated pin is found.
Hi @c9s, Well done! 313 BBG has been sent to your polygon wallet. Please check the following tx: https://polygonscan.com/tx/0x8c681b632ba940123c65c1d650677338a670cb8f447925c5eec98207bf4d7355 Thank you for your contribution! |
No description provided.