Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IMPROVE: improve stop loss methods #1206

Merged
merged 11 commits into from
Jun 29, 2023
Merged

IMPROVE: improve stop loss methods #1206

merged 11 commits into from
Jun 29, 2023

Conversation

c9s
Copy link
Owner

@c9s c9s commented Jun 21, 2023

No description provided.

@bbgokarma-bot
Copy link

Welcome back! @c9s, This pull request may get 244 BBG.

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #1206 (2b65012) into main (6741f8b) will increase coverage by 0.02%.
The diff coverage is 22.85%.

❗ Current head 2b65012 differs from pull request most recent head c4bd5a8. Consider uploading reports for the commit c4bd5a8 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
+ Coverage   20.79%   20.82%   +0.02%     
==========================================
  Files         505      505              
  Lines       34972    35028      +56     
==========================================
+ Hits         7274     7294      +20     
- Misses      27153    27186      +33     
- Partials      545      548       +3     
Impacted Files Coverage Δ
pkg/bbgo/exit_protective_stop_loss.go 0.00% <0.00%> (ø)
pkg/bbgo/exit_roi_stop_loss.go 0.00% <0.00%> (ø)
pkg/bbgo/order_executor_general.go 14.57% <13.79%> (-1.22%) ⬇️
pkg/bbgo/exit.go 2.22% <25.00%> (+1.05%) ⬆️
pkg/types/position.go 40.35% <64.28%> (+2.68%) ⬆️
pkg/bbgo/exit_trailing_stop.go 53.50% <66.66%> (+2.15%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6741f8b...c4bd5a8. Read the comment docs.

@c9s c9s force-pushed the improve/concurrent-stop-loss branch from d416444 to 0360d9f Compare June 28, 2023 10:09
@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 311 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 316 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 338 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 347 BBG

@bbgokarma-bot
Copy link

Re-estimated karma: this pull request may get 462 BBG

@c9s c9s enabled auto-merge June 29, 2023 06:17
@c9s c9s merged commit 3da1458 into main Jun 29, 2023
@c9s c9s deleted the improve/concurrent-stop-loss branch June 29, 2023 06:25
@bbgokarma-bot
Copy link

Hi @c9s,

Well done! 467 BBG has been sent to your polygon wallet. Please check the following tx:

https://polygonscan.com/tx/0xa36e6cbec6db0c2d27ccfc88996757c5686e5f4a23df03bc364f5ec25823013f

Thank you for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants