Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect correct level color for gauge with more than one data value per series #2755

Merged
merged 1 commit into from
Feb 24, 2020
Merged

Detect correct level color for gauge with more than one data value per series #2755

merged 1 commit into from
Feb 24, 2020

Conversation

GDFaber
Copy link
Contributor

@GDFaber GDFaber commented Feb 19, 2020

@codecov-io
Copy link

codecov-io commented Feb 19, 2020

Codecov Report

Merging #2755 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2755   +/-   ##
======================================
  Coverage    82.9%   82.9%           
======================================
  Files          60      60           
  Lines        4791    4791           
======================================
  Hits         3972    3972           
  Misses        819     819
Impacted Files Coverage Δ
src/arc.js 75.08% <100%> (ø) ⬆️
src/legend.js 82.97% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f339e29...89aedaf. Read the comment docs.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GDFaber Looks decent fix to me. Thank you for looking into this!

@kt3k kt3k merged commit 07e8298 into c3js:master Feb 24, 2020
@GDFaber GDFaber deleted the bug/gauge_level_color_for_more_than_one_data_value branch February 24, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gauge shows wrong threshold color if there is more than one data value for the series
3 participants