Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented access to nested JSON objects as values for charts #1625

Closed
wants to merge 1 commit into from

Conversation

kelthuzad
Copy link
Contributor

This is the code to implement #1471

Code to access objects by path was taken from the solution of
https://stackoverflow.com/questions/6491463

When JSON objects are used to load chart data, nested / inner objects and
arrays can now be loaded, too.
See additional tests in spec/data-spec.js for examples, how to access nested
JSON object values

I also changed the negative precision of some tests because I think they didn't make sense.

Code to access objects by path was taken from the solution of
http://stackoverflow.com/questions/6491463

When JSON objects are used to load chart data, nested / inner objects and
arrays can now be loaded, too.
See additional tests in spec/data-spec.js for examples, how to access nested
JSON object values
@aendra-rininsland
Copy link
Member

Lovely PR! I've merged it into dev.

@aendra-rininsland aendra-rininsland added the C-feature-request Category: A feature request or an enhancement label Apr 30, 2016
@aendra-rininsland aendra-rininsland added this to the 0.4.11 milestone Apr 30, 2016
@aendra-rininsland aendra-rininsland added R-needs-docs Request for changes: The PR needs documentation Merged into dev branch labels Apr 30, 2016
@aendra-rininsland aendra-rininsland removed this from the 0.4.11 milestone Apr 30, 2016
@masayuki0812
Copy link
Member

This has been released in 0.4.11. Thanks!

@kelthuzad
Copy link
Contributor Author

Nice, glad I could help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-feature-request Category: A feature request or an enhancement R-needs-docs Request for changes: The PR needs documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants