Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .scss source files to bower package #1390

Merged
merged 1 commit into from
May 21, 2017

Conversation

MarcBT
Copy link
Contributor

@MarcBT MarcBT commented Sep 22, 2015

Hi !
It can be useful to have access to .scss files in the bower package for some cases.
As an exemple, it can simplify a gulp / grunt / brunch task handling styles when all the bower components of the project expose their .scss source files.
Regards.

@aendra-rininsland
Copy link
Member

@MarcBT Hi!

I don't disagree at all with adding .scss to bower.json, but that's not at all what your commit does — it simply adds src/**/*.js to bower.json's ignore. This actually removes stuff from bower instead of adds it...

If you amend your PR to in fact include the Sass files, I'll RTBC. Thanks!

Hurr, I'm having a really slow morning, forgot the scss folder was in src. LGTM, 👍, :shipit:, &c. Merge away, @masayuki0812!

@MarcBT
Copy link
Contributor Author

MarcBT commented Sep 24, 2015

From bower doc, Bower ignore follows the same rule as gitignore pattern spec.
If you prefer, I can change the PR to make it match the latest exemple provided in gitignore documenation.
Just let me know!

@aendra-rininsland
Copy link
Member

@MarcBT If you want to make it a bit easier to initially understand, maybe like:

'src/',
'!src/scss/`

Or something like that? Regardless, it doesn't really matter, your PR's perfectly fine!

@MarcBT
Copy link
Contributor Author

MarcBT commented Sep 25, 2015

All right ! So let's maintain like this so that no need to amend the commit.
Thanks @Aendrew.

@kt3k
Copy link
Member

kt3k commented May 21, 2017

Thanks for the contribution!

@kt3k kt3k merged commit 6ab630b into c3js:master May 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants