Ie9 csv fix #1345
Closed
Ie9 csv fix #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 21, 2015 15:21
… param of xhr callback object. Copy responseText param to response param fixed the issue. Charts now render correctly.
|
Hi @jfrazier! Apologies for the incredibly long delay in getting to this PR! LGTM, will happily merge it. First though —
Thank you! |
|
Going to merge with appending comments. ( Approved by @masayuki0812 . |
aendra-rininsland
pushed a commit
to aendra-rininsland/c3
that referenced
this pull request
Jun 10, 2017
* Fixes error parsing csv from xhr request callback object * Fixes error in IE9 when parsing csv files. IE9 doesn't support response param of xhr callback object. Copy responseText param to response param fixed the issue. Charts now render correctly.
|
Merged in 6f3deac. |
|
Published at v0.4.13. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error parsing csv from xhr request callback object