Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds function handling for point's size on focus and select #1571

Closed
panthony opened this issue Feb 5, 2016 · 2 comments · Fixed by #1704
Closed

Adds function handling for point's size on focus and select #1571

panthony opened this issue Feb 5, 2016 · 2 comments · Fixed by #1704
Labels
C-feature-request Category: A feature request or an enhancement

Comments

@panthony
Copy link
Contributor

panthony commented Feb 5, 2016

The options point.focus.expand.r and point.select.r should both be able to take a function with either the data or the current point size.

Today when you use a function for point.r to make the point's size vary according to some data the default ratio of 4 and 1.75.

I'd be happy to provide a PR if I knew it would be merged eventually.
@aendra-rininsland aendra-rininsland added the C-feature-request Category: A feature request or an enhancement label Feb 18, 2016
@aendra-rininsland
Copy link
Member

Agreed, this should take an optional callback.

@panthony
Copy link
Contributor Author

This ticket was partially fixed by #1610.

Now only point.focus.expand.r is missing the handling of function as value.

panthony added a commit to cogniteev/c3 that referenced this issue May 20, 2016
@panthony
Focused radius now can accept a function
9e102d5 
It fixes c3js#1571
@panthony panthony mentioned this issue May 20, 2016
Merged
kt3k pushed a commit that referenced this issue Aug 23, 2017
@panthony @kt3k
Focused radius now can accept a function (#1704)
b7a2e6c 
It fixes #1571
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-feature-request Category: A feature request or an enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

point.focus.expand.r can now take a function cogniteev/c3
2 participants
@aendra-rininsland @panthony