Fix for slocums, to interpolate over gaps smaller than 'maxgap' #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A new function `find_gaps` has been added to utils.py, which identified gaps in scientific variables, and fills those gaps longer than the user-specified paramter `maxgap` with nans.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
==========================================
+ Coverage 79.47% 79.62% +0.14%
==========================================
Files 7 7
Lines 1364 1374 +10
==========================================
+ Hits 1084 1094 +10
Misses 280 280
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
jklymak
reviewed
Apr 15, 2023
pyglider/slocum.py
Outdated
| try: | ||
| tg_ind = utils.find_gaps(_t,time,maxgap) | ||
| val[tg_ind] = np.nan | ||
| except ValueError: |
There was a problem hiding this comment.
Did you hit this exception? Why? A print statement probably is wrong. Either warm or log.
There was a problem hiding this comment.
I never hit the exception, and the print statement should've been removed after testing. I've done that now. Thanks!
jklymak
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new function
find_gapshas been added toutils.py, which identified gaps in scientific variables, and fills any gaps longer than the user-specified parametermaxgapwith nans.